chore(osmosis-outpost): add receiver address validation

CHANGELOG.md

@@ -97,6 +97,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 - (staking) [#2053](https://github.com/evmos/evmos/pull/2053) Change the validator address in the events from string type to address type.
 - (werc20) [#2057](https://github.com/evmos/evmos/pull/2057) WERC20 refactors and handling of fallback and receive functions.
 - (werc20) [#2062](https://github.com/evmos/evmos/pull/2062) Remove name checking for `fallback` and `receive` functions.
+- (osmosis-outpost) [#202063](https://github.com/evmos/evmos/pull/2063) Check that receiver address is bech32 with "evmos" as human readable part.
 
 ### Bug Fixes
 

precompiles/outposts/osmosis/errors.go

@@ -5,9 +5,6 @@ package osmosis
 import "fmt"
 
 var (
-	// ErrEmptyReceiver is raised when the receiver used in the memo is an
-	// empty string.
-	ErrEmptyReceiver = "receiver address cannot be empty"
 	// ErrEmptyOnFailedDelivery is raised when the onFailedDeliver field of the
 	// IBC memo is an empty string.
 	ErrEmptyOnFailedDelivery = "onFailedDelivery cannot be empty"
@@ -25,4 +22,7 @@ var (
 	// ErrInputTokenNotSupported is raised when the osmosis outpost receives a non-supported
 	// input token for the swap.
 	ErrInputTokenNotSupported = "input not supported, supported tokens: %v" //#nosec G101 -- no hardcoded credentials here
+	// ErrReceiverAddress is raised when an error occurs during the validation of the receiver of the
+	// swap.
+	ErrReceiverAddress = "error during receiver address validation: %s"
 )

precompiles/outposts/osmosis/tx_test.go

@@ -27,7 +27,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 	senderAddress := utiltx.GenerateAddress()
 	sender := sdktypes.AccAddress(senderAddress.Bytes())
 	randomAddress := utiltx.GenerateAddress()
-	osmoAddress := "osmo1qql8ag4cluz6r4dz28p3w00dnc9w8ueuhnecd2"
+	receiver := "evmos1vl0x3xr0zwgrllhdzxxlkal7txnnk56q3552x7" //nolint:goconst
 
 	method := s.precompile.Methods[osmosis.SwapMethod]
 	testCases := []struct {
@@ -60,7 +60,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 					transferAmount,
 					slippagePercentage,
 					windowSeconds,
-					osmoAddress,
+					receiver,
 				}
 			},
 			expError:    true,
@@ -80,7 +80,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 					transferAmount,
 					slippagePercentage,
 					windowSeconds,
-					osmoAddress,
+					receiver,
 				}
 			},
 			expError:    true,
@@ -100,7 +100,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 					transferAmount,
 					slippagePercentage,
 					windowSeconds,
-					osmoAddress,
+					receiver,
 				}
 			},
 			expError:    true,
@@ -120,7 +120,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 					transferAmount,
 					slippagePercentage,
 					windowSeconds,
-					osmoAddress,
+					receiver,
 				}
 			},
 			expError:    true,
@@ -148,7 +148,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 					transferAmount,
 					slippagePercentage,
 					windowSeconds,
-					osmoAddress,
+					receiver,
 				}
 			},
 			expError: true,
@@ -169,7 +169,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 					transferAmount,
 					slippagePercentage,
 					windowSeconds,
-					osmoAddress,
+					receiver,
 				}
 			},
 			expError:    true,
@@ -193,7 +193,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 					transferAmount,
 					slippagePercentage,
 					windowSeconds,
-					osmoAddress,
+					receiver,
 				}
 			},
 			expError: true,
@@ -222,7 +222,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 				}
 			},
 			expError:    true,
-			errContains: "invalid separator",
+			errContains: fmt.Sprintf(osmosis.ErrReceiverAddress, "not a valid evmos address"),
 		}, {
 			//  THIS PANICS INSIDE CheckAuthzExists
 			name:   "fail - origin different from address caller",
@@ -243,7 +243,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 					transferAmount,
 					slippagePercentage,
 					windowSeconds,
-					osmoAddress,
+					receiver,
 				}
 			},
 			expError:    true,
@@ -267,7 +267,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 					transferAmount,
 					slippagePercentage,
 					windowSeconds,
-					osmoAddress,
+					receiver,
 				}
 			},
 			expError:    true,
@@ -291,7 +291,7 @@ func (s *PrecompileTestSuite) TestSwap() {
 					transferAmount,
 					slippagePercentage,
 					windowSeconds,
-					osmoAddress,
+					receiver,
 				}
 			},
 			expError: false,

precompiles/outposts/osmosis/types.go

@@ -9,13 +9,11 @@ import (
 	"math/big"
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
-	"github.com/cosmos/cosmos-sdk/types/address"
 	"github.com/evmos/evmos/v15/utils"
 	"golang.org/x/exp/slices"
 
 	cosmosbech32 "github.com/cosmos/cosmos-sdk/types/bech32"
 
-	"github.com/cosmos/btcutil/bech32"
 	"github.com/ethereum/go-ethereum/common"
 	cmn "github.com/evmos/evmos/v15/precompiles/common"
 )
@@ -98,6 +96,32 @@ type Memo struct {
 	Msg *Msg `json:"msg"`
 }
 
+// Validate performs basic validation of the IBC memo for the Osmosis outpost.
+// This function assumes that memo field is parsed with ParseSwapPacketData, which
+// performs data casting ensuring outputDenom cannot be an empty string.
+func (m Memo) Validate() error {
+	osmosisSwap := m.Msg.OsmosisSwap
+
+	if osmosisSwap.OnFailedDelivery == "" {
+		return fmt.Errorf(ErrEmptyOnFailedDelivery)
+	}
+
+	// Check if account is a valid bech32 address
+	if _, err := sdk.AccAddressFromBech32(osmosisSwap.Receiver); err != nil {
+		return fmt.Errorf(ErrReceiverAddress, "not a valid evmos address")
+	}
+
+	if osmosisSwap.Slippage.TWAP.SlippagePercentage == 0 || osmosisSwap.Slippage.TWAP.SlippagePercentage > MaxSlippagePercentage {
+		return fmt.Errorf(ErrSlippagePercentage)
+	}
+
+	if osmosisSwap.Slippage.TWAP.WindowSeconds == 0 || osmosisSwap.Slippage.TWAP.WindowSeconds > MaxWindowSeconds {
+		return fmt.Errorf(ErrWindowSeconds)
+	}
+
+	return nil
+}
+
 // RawPacketMetadata is the raw packet metadata used to construct a JSON string.
 type RawPacketMetadata struct {
 	// The Osmosis outpost IBC memo.
@@ -145,33 +169,6 @@ func (r RawPacketMetadata) String() string {
 	return string(jsonBytes)
 }
 
-// Validate performs basic validation of the IBC memo for the Osmosis outpost.
-// This function assumes that memo field are parsed with ParseSwapPacketData, which
-// performs data casting ensuring outputDenom cannot be an empty string.
-func (m Memo) Validate() error {
-	osmosisSwap := m.Msg.OsmosisSwap
-
-	if osmosisSwap.OnFailedDelivery == "" {
-		return fmt.Errorf(ErrEmptyOnFailedDelivery)
-	}
-
-	// Check if account is a valid bech32 address
-	_, _, err := bech32.Decode(osmosisSwap.Receiver, address.MaxAddrLen)
-	if err != nil {
-		return err
-	}
-
-	if osmosisSwap.Slippage.TWAP.SlippagePercentage == 0 || osmosisSwap.Slippage.TWAP.SlippagePercentage > MaxSlippagePercentage {
-		return fmt.Errorf(ErrSlippagePercentage)
-	}
-
-	if osmosisSwap.Slippage.TWAP.WindowSeconds == 0 || osmosisSwap.Slippage.TWAP.WindowSeconds > MaxWindowSeconds {
-		return fmt.Errorf(ErrWindowSeconds)
-	}
-
-	return nil
-}
-
 // CreateOnFailedDeliveryField is an utility function to create the memo field
 // onFailedDelivery. The returned string is the bech32 of the receiver input
 // or "do_nothing".