Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(erc20): minor alignments between ERC20 extension and contracts #2067

Merged
merged 9 commits into from Nov 23, 2023

Conversation

MalteHerrmann
Copy link
Contributor

Description

This PR takes some of the findings from #2044 and aligns our ERC20 EVM extension with the way things are handled on the actual Solidity contracts.

@MalteHerrmann MalteHerrmann requested a review from a team as a code owner November 22, 2023 15:42
@MalteHerrmann MalteHerrmann requested review from facs95 and GAtom22 and removed request for a team November 22, 2023 15:42
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

precompiles/erc20/errors.go Outdated Show resolved Hide resolved
precompiles/erc20/errors.go Show resolved Hide resolved
precompiles/erc20/approve.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Vvaradinov Vvaradinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor Author

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some more refactors on the errors, addressed the comments 👍 will merge then

precompiles/erc20/errors.go Outdated Show resolved Hide resolved
precompiles/erc20/approve.go Outdated Show resolved Hide resolved
@MalteHerrmann MalteHerrmann merged commit ac21bae into main Nov 23, 2023
27 checks passed
@MalteHerrmann MalteHerrmann deleted the malte/adjust-erc20-extension branch November 23, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants