tests(erc20): add integration tests for the ERC20 extension #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalteHerrmann
commented
Nov 15, 2023
fedekunze
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Great work @MalteHerrmann, we need to test that the contract and direct calls match the behaviour with the normal ERC-20 contracts that we have now deployed on Evmos for the registered coins. I suggest adding it to the DescribeTables and comparing the call to the ERC-20 vs EVM Extension
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2044 +/- ##
==========================================
+ Coverage 70.17% 70.34% +0.16%
==========================================
Files 353 353
Lines 25948 25948
==========================================
+ Hits 18210 18253 +43
+ Misses 6792 6748 -44
- Partials 946 947 +1 |
MalteHerrmann
requested review from
Vvaradinov and
facs95
and removed request for
a team
MalteHerrmann
commented
Nov 27, 2023
Comment on lines
+370
to
+373
| // FIXME: The gas used on the precompile is much higher than on the EVM | ||
| Entry(" - direct call", directCall, int64(3_021_572)), | ||
| Entry(" - through erc20 contract", erc20Call, int64(54_381)), | ||
| Entry(" - through erc20 v5 contract", erc20V5Call, int64(52_122)), |
There was a problem hiding this comment.
We'll have to address the gas usage still, as it is right now, the call the to EVM extension is using way more gas than the call to the Solidity contract.
|
As per discussion with @0xstepit this PR will be split into smaller PRs ⛏️ |
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests to the ERC20 EVM extension.
Closes ENG-2319