Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(erc20): Add ERC20 query integration tests #2081

Merged
merged 5 commits into from Nov 28, 2023

Conversation

MalteHerrmann
Copy link
Contributor

Description

This PR adds integration tests for the standard ERC20 queries as part of merging #2044 in smaller chunks.

@MalteHerrmann MalteHerrmann requested a review from a team as a code owner November 27, 2023 16:31
@MalteHerrmann MalteHerrmann requested review from Vvaradinov and facs95 and removed request for a team November 27, 2023 16:31
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, what about the name, symbol and decimals though

@MalteHerrmann
Copy link
Contributor Author

ACK, what about the name, symbol and decimals though

That's on a separate PR 👍

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #2081 (0349060) into main (97307ca) will decrease coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

❗ Current head 0349060 differs from pull request most recent head f36d5f6. Consider uploading reports for the commit f36d5f6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2081      +/-   ##
==========================================
- Coverage   70.14%   70.13%   -0.02%     
==========================================
  Files         339      339              
  Lines       25499    25499              
==========================================
- Hits        17887    17884       -3     
- Misses       6675     6677       +2     
- Partials      937      938       +1     

see 1 file with indirect coverage changes

@MalteHerrmann MalteHerrmann enabled auto-merge (squash) November 28, 2023 12:22
@fedekunze fedekunze merged commit 911e4a7 into main Nov 28, 2023
21 of 24 checks passed
@fedekunze fedekunze deleted the malte/add-erc20-query-integration-tests branch November 28, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants