Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove claims mod & migrate EVMChannels param to evm params #2084

Merged
merged 28 commits into from Nov 29, 2023

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Nov 27, 2023

Description


Closes ENG-2335

@github-actions github-actions bot added the proto label Nov 27, 2023
@GAtom22 GAtom22 changed the title G atom22/migrate params chore: migrate claims params to evm Nov 27, 2023
Copy link

linear bot commented Nov 27, 2023

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #2084 (8f4c058) into main (323b733) will decrease coverage by 1.27%.
Report is 6 commits behind head on main.
The diff coverage is 68.69%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2084      +/-   ##
==========================================
- Coverage   70.27%   69.00%   -1.27%     
==========================================
  Files         339      301      -38     
  Lines       25538    23573    -1965     
==========================================
- Hits        17946    16266    -1680     
+ Misses       6654     6423     -231     
+ Partials      938      884      -54     
Files Coverage Δ
app/keys.go 100.00% <100.00%> (ø)
x/erc20/keeper/ibc_callbacks.go 95.41% <100.00%> (ø)
x/erc20/keeper/keeper.go 88.23% <ø> (-0.66%) ⬇️
x/ibc/transfer/keeper/msg_server.go 100.00% <ø> (ø)
x/inflation/v1/keeper/hooks.go 75.78% <ø> (+4.91%) ⬆️
x/inflation/v1/keeper/inflation.go 86.20% <ø> (+1.67%) ⬆️
x/inflation/v1/types/params.go 79.06% <ø> (-6.98%) ⬇️
app/app.go 79.43% <75.00%> (-0.73%) ⬇️
x/evm/keeper/migrations.go 63.63% <0.00%> (-14.15%) ⬇️
x/evm/migrations/v6/migrate.go 88.46% <88.46%> (ø)
... and 3 more

@GAtom22 GAtom22 marked this pull request as ready for review November 27, 2023 17:16
@GAtom22 GAtom22 requested a review from a team as a code owner November 27, 2023 17:16
@GAtom22 GAtom22 requested review from facs95, MalteHerrmann, Vvaradinov, fedekunze and 0xstepit and removed request for a team November 27, 2023 17:16
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GAtom22, we will need to perform a store migration and register it on module.go instead of doing it through regular upgrade handler

app/upgrades/v16/upgrades.go Outdated Show resolved Hide resolved
x/evm/types/params.go Outdated Show resolved Hide resolved
x/evm/types/params.go Outdated Show resolved Hide resolved
proto/ethermint/evm/v1/evm.proto Outdated Show resolved Hide resolved
@fedekunze fedekunze marked this pull request as draft November 28, 2023 13:08
@github-actions github-actions bot added the CLI label Nov 28, 2023
@GAtom22 GAtom22 changed the title chore: migrate claims params to evm chore: remove claims mod & migrate EVMChannels param to evm params Nov 28, 2023
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/evm/migrations/v6/migrate_test.go Outdated Show resolved Hide resolved
@fedekunze fedekunze marked this pull request as ready for review November 28, 2023 18:42
app/app.go Show resolved Hide resolved
Copy link
Contributor

@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @GAtom22 !

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GAtom22 the migration of the EVM module needs to be registered in the RegisterServices function in module.go

if err := cfg.RegisterMigration(types.ModuleName, 5, m.Migrate5to6); err != nil {
	panic(err)
}

Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @GAtom22 🚀

app/app.go Outdated Show resolved Hide resolved
x/erc20/keeper/ibc_callbacks_test.go Outdated Show resolved Hide resolved
x/evm/migrations/v6/migrate.go Outdated Show resolved Hide resolved
x/evm/types/params.go Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit 6080ed9 into main Nov 29, 2023
35 of 39 checks passed
@fedekunze fedekunze deleted the GAtom22/migrate-params branch November 29, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants