New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove claims mod & migrate EVMChannels
param to evm params
#2084
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2084 +/- ##
==========================================
- Coverage 70.27% 69.00% -1.27%
==========================================
Files 339 301 -38
Lines 25538 23573 -1965
==========================================
- Hits 17946 16266 -1680
+ Misses 6654 6423 -231
+ Partials 938 884 -54
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GAtom22, we will need to perform a store migration and register it on module.go instead of doing it through regular upgrade handler
… into GAtom22/migrate-params
EVMChannels
param to evm params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @GAtom22 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GAtom22 the migration of the EVM module needs to be registered in the RegisterServices
function in module.go
if err := cfg.RegisterMigration(types.ModuleName, 5, m.Migrate5to6); err != nil {
panic(err)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @GAtom22 🚀
Description
Closes ENG-2335