tests(erc20): Add ERC20 metadata query integration tests

[MalteHerrmann]

Description

This PR adds integration tests for the ERC20 EVM extension metadata queries, which is part of merging #2044 in smaller chunks.

[fedekunze]

ACK but what about tests for deriving the name from the IBC voucher? Do we have those?

[Vvaradinov]

LGTM!

[MalteHerrmann]

ACK but what about tests for deriving the name from the IBC voucher? Do we have those?

I had those included originally, but we had to manually store the IBC denom in the transfer keeper and Freddy suggested not to access any keepers in the integration tests, which is why I removed those tests in the integration setup.

Those cases are fully covered by unit tests though (and it also worked when I had those included in integration tests), check here:

evmos/precompiles/erc20/query_test.go

Lines 135 to 182 in 3c22225

	{
	name: "fail - invalid denom (too short < 3 chars)",
	denom: tooShortTrace.IBCDenom(),
	malleate: func(ctx sdk.Context, app *app.Evmos) {
	app.TransferKeeper.SetDenomTrace(ctx, tooShortTrace)
	},
	errContains: vm.ErrExecutionReverted.Error(),
	},
	{
	name: "fail - denom without metadata and not an IBC voucher",
	denom: "noIBCvoucher",
	errContains: vm.ErrExecutionReverted.Error(),
	},
	{
	name: "pass - valid ibc denom without metadata and neither atto nor micro prefix",
	denom: validTraceDenomNoMicroAtto.IBCDenom(),
	malleate: func(ctx sdk.Context, app *app.Evmos) {
	app.TransferKeeper.SetDenomTrace(ctx, validTraceDenomNoMicroAtto)
	},
	expPass: true,
	expName: "Evmos",
	expSymbol: "EVMOS",
	},
	{
	name: "pass - valid denom with metadata",
	denom: validMetadataDenom,
	malleate: func(ctx sdk.Context, app *app.Evmos) {
	// NOTE: we mint some coins to the inflation module address to be able to set denom metadata
	err := app.BankKeeper.MintCoins(ctx, inflationtypes.ModuleName, sdk.Coins{sdk.NewInt64Coin(validMetadata.Base, 1)})
	s.Require().NoError(err)
	// NOTE: we set the denom metadata for the coin
	app.BankKeeper.SetDenomMetaData(ctx, validMetadata)
	},
	expPass: true,
	expName: "Atom",
	expSymbol: "ATOM",
	},
	{
	name: "pass - valid ibc denom without metadata",
	denom: validTraceDenom.IBCDenom(),
	malleate: func(ctx sdk.Context, app *app.Evmos) {
	app.TransferKeeper.SetDenomTrace(ctx, validTraceDenom)
	},
	expPass: true,
	expName: "Osmo",
	expSymbol: "OSMO",
	},

[codecov]

Codecov Report

Merging #2086 (e96d0fb) into main (f909c22) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2086      +/-   ##
==========================================
+ Coverage   70.06%   70.14%   +0.07%     
==========================================
  Files         339      339              
  Lines       25499    25499              
==========================================
+ Hits        17867    17887      +20     
+ Misses       6697     6675      -22     
- Partials      935      937       +2     

see 1 file with indirect coverage changes