-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp(osmosis-outpost): Make the input to the swap function a struct and refactor tests #2206
Conversation
…tor' into Vvaradinov/osmosis-outpost-refactor
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2206 +/- ##
==========================================
- Coverage 70.54% 70.47% -0.07%
==========================================
Files 291 291
Lines 22672 22629 -43
==========================================
- Hits 15993 15947 -46
- Misses 5807 5809 +2
- Partials 872 873 +1
|
I like the approach of reducing the number of inputs in functions but to be honest I don't see any advantage in doing it in this case. We should avoid >2/3 inputs in internal functions because it will make maintainability easier and the code cleaner. But, what is the purpose of using a struct to group all inputs from the user API like a contract? The user should pass the same number of params AND group them in a struct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to remove the wevmos logic from the nix tests here to avoid getting error. Similarly to how we did it on the release/v16 branch. The thing is that we removed the registerCoin proposal from main. That's what the error is about.
I guess we'll need a wevmos address from genesis according to the logic we have now.
@GAtom22 since we were merging to the release branch directly the logic is not here, but I think we should merge back and make the main branch up to date before merging it to the release branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @Vvaradinov!!
Description
This PR creates a struct type for the Osmosis outpost input params to keep the validation and parsing cleaner. It also implements the Outpost Client Arguments ADR by passing extra params like
channelID
andXCSContract
.Closes XAP-10