imp(tests): Check voting has concluded in automated upgrade tests

[MalteHerrmann]

Description

This PR improves the automated upgrade tests, by making sure that the proposal actually has passed when stopping the original node and before starting the upgraded node.

To prevent some future problems when adjusting e.g. init-node.sh the scheduled upgrade height is calculated dynamically from the timeout_commit and voting_period of the running node.

[codecov]

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (85fc042) 70.72% compared to head (062a24e) 70.53%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2235      +/-   ##
==========================================
- Coverage   70.72%   70.53%   -0.20%     
==========================================
  Files         293      293              
  Lines       22551    22613      +62     
==========================================
  Hits        15950    15950              
- Misses       5734     5796      +62     
  Partials      867      867              

Files	Coverage Δ
tests/e2e/upgrade/params.go	90.72% <ø> (ø)
tests/e2e/upgrade/queryexec.go	0.00% <0.00%> (ø)
tests/e2e/upgrade/govexec.go	0.00% <0.00%> (ø)
tests/e2e/upgrade/manager.go	0.00% <0.00%> (ø)

[Vvaradinov]

tACK. Maybe we should consider renaming these tests to upgrade ?

[MalteHerrmann]

tACK. Maybe we should consider renaming these tests to upgrade ?

Definitely want to adjust the names on these - for that I want to port the TestCLITxs to nix first and then have only the upgrade tests running like in this suite 👍