fix(wevmos): make WEVMOS deposit and withdraw functions real no-ops and fix tests #2329
Conversation
Vvaradinov
requested review from
MalteHerrmann and
GAtom22
and removed request for
a team
|
Warning Rate Limit Exceeded@Vvaradinov has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 12 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates focus on refining the handling of deposit and withdrawal events within the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- precompiles/werc20/integration_test.go (14 hunks)
- precompiles/werc20/tx.go (2 hunks)
- precompiles/werc20/werc20.go (1 hunks)
Additional comments: 18
precompiles/werc20/tx.go (2)
- 18-18: The
Depositfunction has been correctly updated to perform no operations, aligning with the PR objectives.- 25-25: The
Withdrawfunction has been correctly updated to perform no operations, aligning with the PR objectives.precompiles/werc20/werc20.go (1)
- 117-120: The logic in the
Runfunction correctly handles calls to theDepositandWithdrawmethods as no-ops, consistent with the PR objectives.precompiles/werc20/integration_test.go (15)
- 26-31: The introduction of
EventTypeDepositandEventTypeWithdrawalconstants is appropriate for handling event types in tests, improving readability and maintainability.- 104-104: The gas consumption check for the
Depositmethod correctly reflects its new no-op nature.- 117-117: The gas consumption check for the
Withdrawmethod correctly reflects its new no-op nature.- 136-136: The balance check logic in the test case for calling with incomplete data correctly reflects the expected behavior.
- 152-152: The balance check logic in the test case for calling with short call data correctly reflects the expected behavior.
- 168-168: The balance check logic in the test case for calling with non-existing function correctly reflects the expected behavior.
- 182-182: The balance check logic in the test case for calling without call data and without amount correctly reflects the expected behavior.
- 197-197: The balance check logic in the test case for calling with short call data and without amount correctly reflects the expected behavior.
- 212-212: The balance check logic in the test case for calling with non-existing function and without amount correctly reflects the expected behavior.
- 242-242: The gas consumption comparison between the precompile and the original contract for the
Depositmethod is correctly set up in the test.- 261-261: The error handling comparison between the precompile and the original contract for the
Depositmethod with insufficient balance is correctly set up in the test.- 282-282: The balance reflection test for the
Depositmethod correctly compares the precompile and the original contract.- 318-318: The setup for the
Withdrawmethod test by depositing into the WEVMOS contract is correctly implemented.- 328-328: The gas consumption comparison between the precompile and the original contract for the
Withdrawmethod is correctly set up in the test.- 344-344: The error handling comparison between the precompile and the original contract for the
Withdrawmethod is correctly set up in the test.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- precompiles/werc20/integration_test.go (14 hunks)
Files skipped from review as they are similar to previous changes (1)
- precompiles/werc20/integration_test.go
Additional comments: 1
CHANGELOG.md (1)
- 73-73: The changelog entry correctly documents the change to the
wevmosmodule, making thedepositandwithdrawfunctions no-ops.
Description
This PR makes the
WEVMOSprecompiled contract functionswithdrawanddepositreal no-ops without emitting events or modifying the StateDB.Closes: XAP-103
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.mdSummary by CodeRabbit
werc20package functionality by removing input parameters from theDepositandWithdrawfunctions to streamline their operations.DepositandWithdrawmethods in thePrecompilestruct of thewerc20.gofile to no longer accept certain arguments, impacting WERC20 transaction behavior.