Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Remove configuration for deprecated modules from local node script #2421

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

MalteHerrmann
Copy link
Contributor

Description

This PR adds a minor improvement to the local node script. Prior, the total supply was hardcoded and would have to be updated manually if either the genesis accounts or their corresponding balances were changed.

@MalteHerrmann MalteHerrmann marked this pull request as ready for review March 18, 2024 11:11
@MalteHerrmann MalteHerrmann requested a review from a team as a code owner March 18, 2024 11:11
@MalteHerrmann MalteHerrmann requested review from hanchon and 0xstepit and removed request for a team March 18, 2024 11:11
@MalteHerrmann MalteHerrmann changed the title make supply calc more robust imp(tests): Remove hardcoded supply in local node script Mar 18, 2024
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the claims, crisis and components that are now deprecated

@MalteHerrmann MalteHerrmann changed the title imp(tests): Remove hardcoded supply in local node script imp(tests): Remove hardcoded supply in local node script and remove outdated setup Mar 19, 2024
@MalteHerrmann MalteHerrmann changed the title imp(tests): Remove hardcoded supply in local node script and remove outdated setup imp(tests): Remove configuration for deprecated modules from local node script Mar 19, 2024
@MalteHerrmann MalteHerrmann changed the title imp(tests): Remove configuration for deprecated modules from local node script chore(tests): Remove configuration for deprecated modules from local node script Mar 19, 2024
@MalteHerrmann
Copy link
Contributor Author

Please also remove the claims, crisis and components that are now deprecated

Good point, I changed this PR to remove all that logic. 👍

@GAtom22 GAtom22 merged commit 0575fba into main Mar 19, 2024
48 checks passed
@GAtom22 GAtom22 deleted the malte/minor-improvement-local-node-script branch March 19, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants