Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG 533 add Enable Inflation param #369

Merged
merged 11 commits into from
Mar 8, 2022

Conversation

danburck
Copy link
Contributor

@danburck danburck commented Mar 7, 2022

Description

This PR adds an enableInflation param and skippedEpochs counter.

Closes ENG-533

@linear
Copy link

linear bot commented Mar 7, 2022

ENG-533 Inflation favors users and validators when claims dashboard doesn't work

To prevent users and validators huge APY while we get the claims dashboard up and running, we can add a enableInflation parameter. Epochs counting should be halted when this param is set to false

@danburck danburck marked this pull request as ready for review March 7, 2022 17:05
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #369 (503d6db) into main (6306f00) will increase coverage by 0.04%.
The diff coverage is 80.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   77.37%   77.42%   +0.04%     
==========================================
  Files          90       90              
  Lines        5317     5373      +56     
==========================================
+ Hits         4114     4160      +46     
- Misses       1052     1058       +6     
- Partials      151      155       +4     
Impacted Files Coverage Δ
x/inflation/types/genesis.go 78.57% <41.66%> (-11.76%) ⬇️
x/inflation/keeper/epoch_info.go 70.00% <70.00%> (ø)
x/inflation/types/params.go 88.88% <81.25%> (-1.74%) ⬇️
x/inflation/keeper/grpc_query.go 84.21% <100.00%> (+4.21%) ⬆️
x/inflation/keeper/hooks.go 94.20% <100.00%> (+2.20%) ⬆️
x/inflation/keeper/keeper.go 89.47% <0.00%> (+10.52%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! can you also update the spec? 🙏

go.mod Outdated Show resolved Hide resolved
proto/evmos/inflation/v1/query.proto Outdated Show resolved Hide resolved
x/inflation/types/params.go Outdated Show resolved Hide resolved
x/inflation/types/params.go Outdated Show resolved Hide resolved
proto/evmos/inflation/v1/query.proto Outdated Show resolved Hide resolved
x/inflation/keeper/hooks.go Outdated Show resolved Hide resolved
x/inflation/keeper/hooks.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@fedekunze
Copy link
Contributor

@danburck we also need to add a migration logic since we are adding a new param

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! can you run:

make proto-gen
make proto-swagger-gen
go mod tidy

@github-actions github-actions bot added the build label Mar 8, 2022
@fedekunze fedekunze merged commit 06cee2a into main Mar 8, 2022
@fedekunze fedekunze deleted the ENG-533-add-Enable-Inflation-param branch March 8, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants