-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audit(fees): specification audit #685
Conversation
ENG-448 Module Specification audit
Improvements found
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the only thing to point out is that 50% of the total tx fee goes to the validator instead of 50% of the base fee (which applies only to DynamicFeeTx
(EIP-1559)).
Ideally, it should be:
- For
Legacy
andAccessList
txs: 50% should go to the validator and 50% to the developer (i.e same logic as now) - For
DynamicFeeTx
:Fee = BaseFee + PriorityFee
. 50% of theBaseFee
should go to the validator and 50% to the developer. 100% of thePriorityFee
should go to the validator. Right now it's 50/50 for theFee
.
EDIT: it's fine as we leave it as is for now and we create an issue to work on it in the future
Description
As part of an internal audit, this PR refactors the specs of the fees module to improve text flow and add missing parts. For reviewers, please use this as an opportunity to fully understand the fees module.