Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Unification Incompatibilities #56

Closed
rwjblue opened this issue Mar 6, 2018 · 2 comments
Closed

Module Unification Incompatibilities #56

rwjblue opened this issue Mar 6, 2018 · 2 comments

Comments

@rwjblue
Copy link

rwjblue commented Mar 6, 2018

This addon has a src/ folder (which it uses for "node land things"), but as of ember-cli@3.2 (current master version of ember-cli) an addon having a src/ folder means it is opting in to Module Unification.

There are a few options that I've listed here, but there definitely may be more that I've not thought of yet:

  1. Move the src/ files to some other directory.
  2. Change the detection that ember-cli does so that this assumption that src/ existing means the addon is using the new module layout is less likely to be breaking for addons (like this one) that already use the src/ folder.
  3. Update this addon to implement isModuleUnification method that always returns false.
  4. Override the this.treePaths.src to point to another folder (other than src/).

I'm mostly only filing this issue because this addon is incompatible with ember-cli#master branch, and I'd like to figure out a nice path forward before users start getting trolled...

@voltidev
Copy link
Collaborator

voltidev commented Mar 6, 2018

Thanks, I'll adjust it soon.

@voltidev
Copy link
Collaborator

voltidev commented Mar 25, 2018

It's fixed in master by renaming the src to lib and removing the build step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants