Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embroider compatibility #495

Merged
merged 1 commit into from Jul 24, 2023

Conversation

nlepage
Copy link
Contributor

@nlepage nlepage commented Jul 24, 2023

Issue

embroider needs to disable ember-auto-import's babel plugin when not necessary.

Solution

Use required.resolve instead of require when adding the plugin to babel's configuration.

Thanks for your work!

@miguelcobain miguelcobain merged commit d6ee812 into evocount:master Jul 24, 2023
@miguelcobain
Copy link
Collaborator

Thank you!
Version 3.0.10 was published with this fix.

@nlepage nlepage deleted the fix-embroider-compatibility branch July 24, 2023 14:09
@nlepage nlepage restored the fix-embroider-compatibility branch July 24, 2023 14:09
@nlepage nlepage deleted the fix-embroider-compatibility branch July 24, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants