Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify axioms to fit OWL DL global constraints #16

Merged
merged 3 commits into from
Jun 27, 2019
Merged

Modify axioms to fit OWL DL global constraints #16

merged 3 commits into from
Jun 27, 2019

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Jun 26, 2019

I changed two axioms that used min 1 with a non-simple property to be some restrictions instead. This is logically equivalent (which is why HermiT never complained). The first commit in this PR resaves using the latest OWL API, resulting in a large number of formatting changes. The second commit is the fix.

The remaining non-DL issue is a problem with the imported ontology-metadata file:

OWL 2 DL Profile Report: Ontology and imports closure NOT in profile. The following violations are present:
Use of undeclared annotation property: <http://purl.org/dc/terms/license> in annotation [Annotation(<http://purl.org/dc/terms/license> "http://creativecommons.org/licenses/by/4.0/") in null]

@balhoff balhoff requested a review from hlapp June 26, 2019 19:41
@balhoff
Copy link
Member Author

balhoff commented Jun 26, 2019

I added a commit to update the version IRI. After merging we should create a tag cdao-rel-2019-06-26.

Copy link
Contributor

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@hlapp hlapp merged commit c0c5083 into master Jun 27, 2019
@hlapp
Copy link
Contributor

hlapp commented Jun 27, 2019

@hlapp hlapp deleted the issue-14 branch June 27, 2019 16:24
@balhoff
Copy link
Member Author

balhoff commented Jun 27, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants