feat: cross compile to Scala 3 #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Z1kkurat
reviewed
Jun 29, 2023
kpodsiad
commented
Jun 30, 2023
|
@kpodsiad no checks were run for some reason 🤔 |
|
@Z1kkurat I was wondering why, but your message made me to go to the actions and search for more details. There was an error in yaml file, but it's really poor UX that one can't see such reason directly in PR :| Fixed now, let's see what the results will be. |
Z1kkurat
approved these changes
Jun 30, 2023
|
CI is green. Coverage decreased a bit but this is probably due to 2 methods being excluded from compat. I got ACK, merging this PR. |
kpodsiad
added a commit
to kpodsiad/scache
that referenced
this pull request
Jul 3, 2023
kpodsiad
added a commit
that referenced
this pull request
Jul 3, 2023
kpodsiad
added a commit
that referenced
this pull request
Jul 3, 2023
kpodsiad
added a commit
that referenced
this pull request
Jul 5, 2023
* port changes source changes from #221 to CatsEffect2 branch * set fail-fast to false in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if I can somehow fix coverage, I might try tomorrow.