Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port changes from Scala 3 migration to Cats Effect 2 branch #224

Merged
merged 4 commits into from
Jul 5, 2023
Merged

port changes from Scala 3 migration to Cats Effect 2 branch #224

merged 4 commits into from
Jul 5, 2023

Conversation

kpodsiad
Copy link
Collaborator

@kpodsiad kpodsiad commented Jul 3, 2023

The main reason to port #221 is to keep sources as closest as possible. In mentioned PR, CacheOpsCompat was created to patch issues with Scala 3 compiler. This PR ports scala-2 structure of mentioned compat.

@kpodsiad
Copy link
Collaborator Author

kpodsiad commented Jul 3, 2023

https://github.com/evolution-gaming/scache/actions/runs/5441751004/jobs/9896073594?pr=224: -1474736480 did not equal -1474636480 (CacheSpec.scala:1487) - interesting 🤔

@kpodsiad
Copy link
Collaborator Author

kpodsiad commented Jul 3, 2023

failing test passes locally, but some other one fails randomly. is it a known issue that tests are flaky or is it my PR which maked them such?

@i-surkov
Copy link
Contributor

i-surkov commented Jul 3, 2023

failing test passes locally, but some other one fails randomly. is it a known issue that tests are flaky or is it my PR which maked them such?

I think I've encountered it before

@kpodsiad
Copy link
Collaborator Author

kpodsiad commented Jul 3, 2023

@i-surkov Do you have any suggestion how to deal with thids problem? I don't know codebase, debugging what's going on isn't appealing to me. I can retrigger actions until one lucky leaves CI in green state but having to repeat that after each release doesn't sounds good for person who will be doing that

@i-surkov
Copy link
Contributor

i-surkov commented Jul 3, 2023

Flaky test is fixed in #226

@kpodsiad kpodsiad merged commit f1b3a1d into series/3.x.x Jul 5, 2023
@kpodsiad kpodsiad deleted the port-scala3-to-CE2 branch July 5, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-surkov i-surkov i-surkov approved these changes

@Z1kkurat Z1kkurat Awaiting requested review from Z1kkurat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpodsiad @i-surkov