Pre-commit fixups #102
Merged
Pre-commit fixups #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use gilt[1] to pull in my Ansible roles, and a series of pre-commit hooks which correct trailing whitespace and newlines. These are triggered when I vendor your project into my repo. Since this doesn't look too controversial, figured I'd submit a PR. [1]: https://gilt.readthedocs.io/en/latest/
|
I will have a more detailed look on monday, but I am not against the idea :) |
evrardjp
approved these changes
Jul 15, 2019
Sounds good... Shout out to openstack-ansible, @major and @cloudnull too :P |
|
Haha, even if those ppl are "has-been" for OSA (like me!), I will convey your regards to those ppl :) Have a good day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use gilt1 to pull in my Ansible roles, and a series of
pre-commit hooks which correct trailing whitespace and
newlines. These are triggered when I vendor your project
into my repo. Since this doesn't look too controversial,
figured I'd submit a PR.