Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single click on cells #181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

damianogiusti
Copy link

This PR fixes an issue which caused the single click listener not to being triggered.
The problem appears when clicking onto a cell (no matter if header or not).

It can be reproduced by launching the example project and single-clicking onto a cell: a Toast will appear incorrectly indicating that a long click has been performed.

The checks using mGestureDetector.onTouchEvent(e) aren't necessary into AbstractItemClickListener subclasses because the methods in which are used are called during a mGestureDetector.onTouchEvent(e) invocation, started from the onInterceptTouchEvent method of the AbstractItemClickListener.

@MGaetan89
Copy link
Contributor

Is this fix still necessary with the latest version of the library? I think some changes were made regarding this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants