feat(Code Signing) windows & mac

README.md

@@ -1,16 +1,22 @@
+# nwsign - test signing nw.js app
 
 # nwjs-builder-phoenix [![npm version](https://img.shields.io/npm/v/nwjs-builder-phoenix.svg)](https://npmjs.org/package/nwjs-builder-phoenix) [![Standard Version](https://img.shields.io/badge/release-standard%20version-brightgreen.svg)](https://github.com/conventional-changelog/standard-version)
 
-A possible solution to build and package a ready for distribution NW.js app for Windows, macOS and Linux.
+A possible solution to build and package a ready for distribution `nw.js`
+app for Windows, macOS and Linux.
 
 ## Why Bother?
 
-We already has official `nw-builder` and `nwjs-builder`, which was built as an alternative before `nw-builder` would support 0.13.x and later versions.
-`nw-builder` has made little progress on the way, and `nwjs-builder` has been hard to continue due to personal and historic reasons.
+`nw-builder` and `nwjs-builder` were built before `nw-builder` supported
+0.13.x and later versions. Both have stalled along the way.
 
-`electron-builder` inspired me when I became an Electron user later, loose files excluding, various target formats, auto updater, artifacts publishing and code signing, amazing!
+When I became an Electron user, `electron-builder` inspired me: one can
+exclude files, support various targets, support auto-updating, publish
+artifacts, and support code signing. It really is a step ahead of `nw.js`.
 
-Although NW.js has much lesser popularity than Electron, and is really troubled by historic headaches, let's have something modern.
+`nw.js` still supports many use cases not supported by Electron, so we
+need something more modern like `electron-builder`, but for `nw.js`.
+That's why `nwjs-builder-phoenix` exists.
 
 ## Features
 
@@ -26,7 +32,7 @@ Although NW.js has much lesser popularity than Electron, and is really troubled
 * `nwjs-ffmpeg-prebuilt` integration
 * [Auto Updater](./packages/nsis-compat-tester/)
 * TODO Rebuilding native modules
-* TODO Code signing
+* Code signing (mac and windows)
 * Ideas appreciated :)
 
 ## Getting Started

assets/nsis/Include/common.nsh

@@ -0,0 +1,10 @@
+!verbose push
+!verbose 4
+!echo "Loading Common Utils"
+!verbose pop
+
+# avoid exit code 2
+!macro quitSuccess
+  SetErrorLevel 0
+  Quit
+!macroend

docs/Options.md

@@ -31,6 +31,9 @@ productVersion | string | Product version. Defaults to `${ version }`.
 fileVersion | string | File version. Defaults to `${ productVersion }`
 versionStrings | { [key: string]: string } | `rcedit` version strings. Defaults to `{}`.
 icon | string | .ico icon file relative to the project root. Defaults to `undefined`.
+signing | `{}` | contains parameters for Microsoft Authenticode signing (optional). If any parameters are included, all parameters are required.
+signing.signtoolPath | string | Absolute path to signing tool, e.g. `"C:\\Program Files (x86)\\Windows Kits\\8.1\\bin\\x64\\signtool.exe"` on windows or `/usr/bin/codesign` on mac. The idea is to provide the full path to the signing executable, and all of the items will be added as arguments to that executable.
+signing.cliArgs | string | Args to pass to the binary at `signing.signtoolPath` EXCEPT for executables to sign. Windows example: `"sign /debug /f E:\\codesigning.crt.pfx /p top$3c37pa$$ /tr http://timestamp.comodoca.com/?td=sha256 /td sha256 /fd sha256 /v"`. Mac example: `--force --verify --sign ${MY_SIGNING_IDENTITY}`
 
 ## build.mac <- [MacConfig](../src/lib/config/MacConfig.ts)