This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
feat(Code Signing) windows & mac #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md
Update nwjs-builder-phoenix
* didn't actually hook it all up yet, though
* working example of signing the HBX Live App!
* refix issue where we got EPERM scandir on glob in signApp * update globby
…ev_code_signing_mac to master * commit '6471c2df4e1aac88ab7851479928c5c8bd2642c2': (21 commits) export spawnAsync remove unneeded appdmg in package.json clarify error message for mac signing create extra arg for nodir:false because of new features in globby make windows signing work again after adding mac signing remove mac signing. see https://stackoverflow.com/q/47820846/78202 remove mac signing. see https://stackoverflow.com/q/47820846/78202 add mac signing add mac signing simplify defualt files to sign globs for mac Add exception handling to env var parsing WIP mac signing - I'm abandoning in favor of simpler approach for now remove spurious file ensure globby behaves correctly and doesn't stall on windows do prep work for signing nsis 7z plugin add signing of uninstaller in nsis target add signing of nsis7z and nsis setup.exe files add dotenv password code signing of directly produced .exe, .dll files add basic code signing of directly produced .exe, .dll files add spawn debug messages to nsis-gen ...
|
This PR addresses #88, feat(code signing). |
codekiln
changed the title
codekiln
commented
Jul 14, 2018
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We needed to be able to pass a password stored in a .env file to the key. That's the point of this block of code.
|
Tagging @kofic since he's worked with this code recently. |
|
I have no experience with code signing and can't simply accept it. It will be excellent if we have tests and docs for it. |
|
why is this PR not getting accepted? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.