Skip to content

Commit

Permalink
☝️ node: Upgrade node tooling (#348)
Browse files Browse the repository at this point in the history
Upgrade node tooling

    (cd .hermit/node/; ncu -u; npm install)
    (cd e2e; ncu -u; npm install)

Manually upgrade playwright docker image use in Makefile to v1.44.0 align with
CLI tooling.

Several new rendering issues showed in the new version, which could eventually
be traced down to an incorrect CSS main wrapper height value of 10% combined
with display flex. The available space is 100% - topnav-height. After this
CSS fix all tests started passing again without updates. Phew.

Pull-request: #348
  • Loading branch information
juliaogris committed May 18, 2024
1 parent 19b9df7 commit 6dd8df0
Show file tree
Hide file tree
Showing 6 changed files with 36 additions and 36 deletions.
36 changes: 18 additions & 18 deletions .hermit/node/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .hermit/node/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"devDependencies": {
"prettier": "^3.2.5",
"stylelint": "^16.3.1",
"stylelint": "^16.5.0",
"stylelint-config-standard": "^36.0.0"
}
}
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ define PLAYWRIGHT_CMD_LOCAL
npx --prefix e2e playwright test --config e2e $(PLAYWRIGHT_ARGS)
endef

PLAYWRIGHT_OCI_IMAGE = mcr.microsoft.com/playwright:v1.41.1-jammy
PLAYWRIGHT_OCI_IMAGE = mcr.microsoft.com/playwright:v1.44.0-jammy
PLAYWRIGHT_CMD_DOCKER = docker run --rm \
--volume $$(pwd):/work/ -w /work/ \
--network host --add-host=host.docker.internal:host-gateway \
Expand Down
26 changes: 13 additions & 13 deletions e2e/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions e2e/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": "true",
"devDependencies": {
"@playwright/test": "^1.41.2",
"playwright": "^1.41.2"
"@playwright/test": "^1.44.0",
"playwright": "^1.44.0"
}
}
2 changes: 1 addition & 1 deletion frontend/play/css/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ button.share > div {
margin-right: auto;
display: flex;
flex-direction: column;
height: 100%;
height: calc(100% - var(--topnav-height));
overflow: clip;
font-family: var(--font-family-code);
font-variant-ligatures: none;
Expand Down

0 comments on commit 6dd8df0

Please sign in to comment.