node: Upgrade node tooling #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade node tooling
(cd .hermit/node/; ncu -u; npm install)
(cd e2e; ncu -u; npm install)
Manually upgrade playwright docker image use in Makefile to v1.44.0 align with
CLI tooling.
Several new rendering issues showed in the new version, which could eventually
be traced down to an incorrect CSS main wrapper height value of 10% combined
with display flex. The available space is 100% - topnav-height. After this
CSS fix all tests started passing again without updates. Phew.
|
firebase-deployment for f970674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade node tooling
Manually upgrade playwright docker image use in Makefile to v1.44.0 align with
CLI tooling.
Several new rendering issues showed in the new version, which could eventually
be traced down to an incorrect CSS main wrapper height value of 10% combined
with display flex. The available space is 100% - topnav-height. After this
CSS fix all tests started passing again without updates. Phew.