lab-site: Add left panel for notes #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaogris
force-pushed
the
labsite-notes
branch
from
1d8706f
to
9cf0fc6
Compare
camh-
reviewed
Aug 4, 2024
There was a problem hiding this comment.
I haven't completed reviewing this yet because I'm stuck again knowing what is generated and what isn't. This PR should have an update to .gitattributes to mark the generated files in /frontend/labs
I have some comments on the notes themselves but I'm not sure where to make those comments
juliaogris
force-pushed
the
labsite-notes
branch
from
9cf0fc6
to
ffec190
Compare
Add left panel for notes added as .htmlf HTML file fragment. A sample x.evy with property `"notes": true` in samples.json will load x.htmlf and present the contents in the left side panel. Rework examples to include notes. Generate SVG files from evy source code.
juliaogris
force-pushed
the
labsite-notes
branch
from
ffec190
to
364c130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add left panel for notes added as .htmlf HTML file fragment. A sample x.evy with
property
"notes": truein samples.json will load x.htmlf and present thecontents in the left side panel on lab.evy.dev. Rework examples to include
notes. Generate SVG files from evy source code.
I considered breaking the commits up a bit further, but decided against it
because they all belong to the same: side notes for lab 1 issue.