Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lab-site: Improve various unrelated aspects of the first labs #407

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

juliaogris
Copy link
Member

  • Improve the HSL example to work with drag and flicker less
  • Add a video embed
  • Fix broken links to docs sites

Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📗

frontend/lab/samples/intro/welcome.htmlf Outdated Show resolved Hide resolved
Re-write "/SUBDOMAIN/..." links in .htmlf files so that the links loaded into
the notes of the labs as .htmlf fragments also have their links re-pointed to
the correct pages. Previously, on lab.evy.dev#var we had the link to `print`
point to https://lab.evy.dev/docs/builtins.html#print (sad 404).
Rework interactive hsl example with more readable code, less flickering and
changes on drag.
Add embedded and styled YouTube player to welcome page with link to Tom's lab 1
walk-through.
Ensure all links from notes open in new tab by using `target="_blank"` in anchor
tag `<a>` everywhere in lab/**/.htmlf files.
Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📗 still LGTM

@juliaogris juliaogris merged commit 3670d07 into main Aug 7, 2024
3 checks passed
@juliaogris juliaogris deleted the lab-fixups branch August 7, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants