Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faucet #21

Closed
lrettig opened this issue Jun 1, 2018 · 13 comments
Closed

Faucet #21

lrettig opened this issue Jun 1, 2018 · 13 comments
Assignees

Comments

@lrettig
Copy link
Member

lrettig commented Jun 1, 2018

Child of #20

@lrettig lrettig added this to the Testnet MVP milestone Jun 1, 2018
@lrettig lrettig added the backlog label Jun 1, 2018
@jwasinger
Copy link
Contributor

I'm adapting the metamask faucet for use in the EWASM testnet. It has not been updated since September 2017 and there have been some breaking changes in the libraries it depends on:

image

@jwasinger
Copy link
Contributor

removing the backlog label as I am actively working on this.

@jwasinger
Copy link
Contributor

It has not been updated since September 2017 and there have been some breaking changes in the libraries it depends on

Oh lol... nvm. I forgot to prefix the address of the faucet with 0x in the config. classic....

@lrettig
Copy link
Member Author

lrettig commented Jun 2, 2018 via email

@lrettig
Copy link
Member Author

lrettig commented Jun 2, 2018

@jwasinger what's the status of this? Is it ready or still WIP?

@jwasinger
Copy link
Contributor

It appears to be working fine.

@lrettig lrettig added review and removed in progress labels Jun 5, 2018
@lrettig
Copy link
Member Author

lrettig commented Jun 6, 2018

@jwasinger's update from today: it works, still need to set up deployment automation, can write something to spin up a node a put the faucet on it, basically Azure node, install ansible, it’s a nodejs app. This also still needs documentation.

@lrettig
Copy link
Member Author

lrettig commented Jun 18, 2018

Update from today: @cdetrio says this is still on the devops to do list but won't require too much work

@axic
Copy link
Member

axic commented Jul 25, 2018

@cdetrio @jwasinger can you please document the version and repo location of the faucet in the testnet repo?

@jwasinger
Copy link
Contributor

https://github.com/ewasm/testnet/compare/eth-faucet?expand=1 . What do you mean by version?

@axic
Copy link
Member

axic commented Jul 25, 2018

I didn't know it was forked, version would have referred to a release if we didn't fork it and there are upstream releases.

@jwasinger
Copy link
Contributor

There is no development activity on the upstream repo. The metamask faucet also appears to be empty.

@axic
Copy link
Member

axic commented Aug 21, 2018

This works now.

@axic axic closed this as completed Aug 21, 2018
@axic axic removed the backlog label Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants