Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate and conflicting geth instructions #115

Merged
merged 3 commits into from
Nov 15, 2018
Merged

Remove duplicate and conflicting geth instructions #115

merged 3 commits into from
Nov 15, 2018

Conversation

axic
Copy link
Member

@axic axic commented Nov 14, 2018

No description provided.

@axic axic requested a review from lrettig November 14, 2018 23:51
@axic axic changed the title Readme duplicate and conflicting geth instructions Remove duplicate and conflicting geth instructions Nov 14, 2018
lrettig
lrettig approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@lrettig lrettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The vmodule arg is slightly different between the two versions but I'll add a note on this to my PR.

@lrettig lrettig mentioned this pull request Nov 15, 2018
Open
@axic axic merged commit 60ba68a into master Nov 15, 2018
@axic axic deleted the readme-dup branch November 15, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrettig lrettig lrettig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@axic @lrettig