Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize core #80

Merged
merged 13 commits into from
Sep 24, 2017
Merged

Modularize core #80

merged 13 commits into from
Sep 24, 2017

Conversation

eweitz
Copy link
Owner

@eweitz eweitz commented Sep 24, 2017

This reduces Ideogram.js's core module from ~2800 lines to ~200 lines. The new highly modular core -- now restored to its original name, ideogram.js -- consists of a simplified constructor method and several small static methods. All instance methods have been moved to new modules:

  • annotations.js
  • bands.js
  • brush.js
  • coordinate-converters.js
  • init.js
  • lib.js
  • services.js
  • sex-chromosomes.js

Refactoring the massive core module into 8 smaller modules significantly improves maintainability.

@eweitz eweitz merged commit 38f5dfb into master Sep 24, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 91.244% when pulling 7922e8c on modular-core into d098689 on master.

@eweitz eweitz deleted the modular-core branch September 27, 2017 00:51
@eweitz eweitz mentioned this pull request Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants