Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hidden samples when exporting raw data from report #387

Closed
annaquaglieri16 opened this issue Jan 12, 2017 · 5 comments
Closed

Ignore hidden samples when exporting raw data from report #387

annaquaglieri16 opened this issue Jan 12, 2017 · 5 comments
Milestone

Comments

@annaquaglieri16
Copy link

Hi there,

I am trying to export the .csv file relative to the GC content plot only for a subset of sample. The export function works fine if I want to export the actual plot but it downloads all the data instead. Is there a way to only download the samples I am interested in, say the ones with warnings?

Thanks for your assistance,
Anna

@ewels
Copy link
Member

ewels commented Jan 12, 2017

Hi Anna,

I'm away at the moment so can't look into this for you right away (I'm back mid-Feb). But if it doesn't already honour renaming and hiding of samples then it probably should, this would be a good addition for the next release.

Thanks!

Phil

@ewels
Copy link
Member

ewels commented Jan 12, 2017

ps. In case you haven't already found it - FastQC plots have a little Pass / Warn / Fail bar next to the title. Clicking this allows you to easily show only failing samples (hiding all other samples across the whole report). If the export data function does already honour these settings, then this will be how to get it.

@annaquaglieri16
Copy link
Author

Thanks for your answer Phil,

I am using the Pass/Warn/Fail selection tool to plot only the samples with issues and I can easily export the subsetted plot. However, when I switch to download data instead of plot it downloads all the samples. Maybe it would be enough to add a factor column (pass-warning-fail) to the downloaded dataset to be able to quickly subset the dataset.

Anna

@ewels
Copy link
Member

ewels commented Feb 17, 2017

Hi @annaquaglieri16,

I'm back from holiday now so will hopefully look into this soon. I think that the expected behaviour is (and should be) that exporting raw data from a report will only export visible samples. So anything hidden through the pass/warn/fail buttons or the more general Toolbox functions should be honoured. I'll update the code so that this is done in the next version.

Cheers,

Phil

@ewels ewels changed the title Exporting data from subset of samples Ignore hidden samples when exporting raw data from report Feb 17, 2017
@ewels ewels modified the milestone: v1.0 May 2, 2017
@ewels ewels closed this as completed in 1a09326 May 16, 2017
@ewels
Copy link
Member

ewels commented May 16, 2017

Hi @annaquaglieri16,

Apologies that this took so long to do - it turned out to be quite a lot more difficult than I expected! I ended up basically rewriting all of the plot data exporting functionality. I think it's quite a bit better now and should work as expected :)

Let me know if it works for you or if you run into any problems..

Phil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants