Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix sample and phenotype extraction for DRAGEN #1537

Merged
merged 1 commit into from Oct 11, 2021
Merged

[bugfix] Fix sample and phenotype extraction for DRAGEN #1537

merged 1 commit into from Oct 11, 2021

Conversation

nh13
Copy link
Contributor

@nh13 nh13 commented Aug 19, 2021 •
edited

DRAGEN metric files named sample.wgs_coverage_metrics.csv would have sample "sample.wgs" and phenotype "" due to incorrect anchoring of a period.

>>> re.search(r"(.*).(\S*)_coverage_metrics_?(\S*)?.csv", "sample-1.wgs_coverage_metrics.csv").groups()
('sample-1.wg', '', '')
>>> re.search(r"(.*)\.(\S*)_coverage_metrics_?(\S*)?.csv", "sample-1.wgs_coverage_metrics.csv").groups()
('sample-1', 'wgs', '')

@jamigo jamigo mentioned this pull request Oct 5, 2021
Closed
ewels
ewels approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot, thanks for the fix! 🎉

@ewels ewels merged commit f9b5171 into MultiQC:master Oct 11, 2021
ewels added a commit that referenced this pull request Oct 11, 2021
@ewels
Changelog for #1537
730ac16
@nh13 nh13 deleted the bugfix/dragen-sample-name-extraction branch October 11, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh13 @ewels