When exporting plots, make a more clear error message for unsupported FastQC dot plot #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladsavelyev
changed the title
ewels
approved these changes
Aug 15, 2023
vladsavelyev
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring while debugging #1873
Per-base content FastQC plot is not supported for export, and currently, there are alert messages shown to warn the user about that. I think one quick improvement here is to specify what type of plot exactly is failing, in case the user would export multiple plots at once.
Further improvements would be to perhaps replace the alert with a more friendly inline warning, or even to fix the export for this plot. But since we will likely be moving away from Highcharts (#1789), it's probably not worth refactoring it much for now.