Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mosdepth: fix prioritizing region over global information #2106

Merged
merged 7 commits into from Oct 17, 2023
Merged

Mosdepth: fix prioritizing region over global information #2106

merged 7 commits into from Oct 17, 2023

Conversation

vladsavelyev
Copy link
Member

  • Fix bug parsing sample summary: when parsing summary, prioritize total_region over total for region-based reports.
  • When both "global" and "region" reports found for the same sample, pick only the "region" report, and discard global information for plots. Add a warning about it into the plot descriptions.

Fixes #2099

@vladsavelyev vladsavelyev added the bug: module Bug in a MultiQC module label Oct 9, 2023
@vladsavelyev vladsavelyev added this to the MultiQC v1.17 milestone Oct 9, 2023
@vladsavelyev vladsavelyev added the awaits-review Awaiting final review and merge. label Oct 9, 2023
ewels
ewels approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@ewels ewels merged commit 4a76790 into master Oct 17, 2023
@ewels ewels deleted the fix-mosdepth branch October 17, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
awaits-review Awaiting final review and merge. bug: module Bug in a MultiQC module
Projects
None yet
Milestone
MultiQC v1.17: Logo and Python 3.12
Development

Successfully merging this pull request may close these issues.

mosdepth module not prioritizing region over global information
3 participants
@vladsavelyev @ewels @multiqc-bot