Do not remove invalid software versions

[ewels]

Added a bit of logic to clean up version strings, and also catch exceptions coming from packaging.version.parse:

  /// MultiQC 🔍 | v1.18.dev0 (c62a430)

|           multiqc | Search path : /Users/ewels/Downloads/multiqc_input
|         searching | ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 84/84
|    custom_content | seqeralabs-nf-aggregate-summary: Found 1 sample (html)
|        seqera_cli | Found 9 reports

Traceback (most recent call last):
  File "/Users/ewels/.miniconda3/miniconda3/envs/py3.10/bin/multiqc", line 8, in <module>
    sys.exit(run_multiqc())
  File "/Users/ewels/GitHub/MultiQC/MultiQC/multiqc/__main__.py", line 23, in run_multiqc
    multiqc.run_cli(prog_name="multiqc")
  File "/Users/ewels/.miniconda3/miniconda3/envs/py3.10/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/Users/ewels/.miniconda3/miniconda3/envs/py3.10/lib/python3.10/site-packages/rich_click/rich_command.py", line 126, in main
    rv = self.invoke(ctx)
  File "/Users/ewels/.miniconda3/miniconda3/envs/py3.10/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/ewels/.miniconda3/miniconda3/envs/py3.10/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/Users/ewels/GitHub/MultiQC/MultiQC/multiqc/multiqc.py", line 300, in run_cli
    multiqc_run = run(**kwargs)
  File "/Users/ewels/GitHub/MultiQC/MultiQC/multiqc/multiqc.py", line 804, in run
    software_versions.update_versions_from_config(config, report)
  File "/Users/ewels/GitHub/MultiQC/MultiQC/multiqc/utils/software_versions.py", line 28, in update_versions_from_config
    versions_from_config = load_versions_from_config(config)
  File "/Users/ewels/GitHub/MultiQC/MultiQC/multiqc/utils/software_versions.py", line 87, in load_versions_from_config
    software_versions_file_tmp, is_valid = validate_software_versions(software_versions_file_tmp)
  File "/Users/ewels/GitHub/MultiQC/MultiQC/multiqc/utils/software_versions.py", line 169, in validate_software_versions
    if not _list_of_versions_is_good(versions):
  File "/Users/ewels/GitHub/MultiQC/MultiQC/multiqc/utils/software_versions.py", line 150, in _list_of_versions_is_good
    elif not packaging.version.parse(item):
  File "/Users/ewels/.miniconda3/miniconda3/envs/py3.10/lib/python3.10/site-packages/packaging/version.py", line 54, in parse
    return Version(version)
  File "/Users/ewels/.miniconda3/miniconda3/envs/py3.10/lib/python3.10/site-packages/packaging/version.py", line 200, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
packaging.version.InvalidVersion: Invalid version: '0.9.0 (build 0cea70d)'

The regex in this PR normalises 0.9.0 (build 0cea70d) to 0.9.0, fixing the issue.

But - honestly, I'm not really sure if we want to do this.

Why do we have to validate that version strings look like version strings? Can we not just accept any string?

Comments like this make me think that the code did that at some point:

Accepts list with both strings and packaging.version.Version objects.

However, as far as I see it, if the version string isn't classic semver / recognised format, it's entirely excluded from the report:

| software_versions | Invalid version: '0.9.0 (build 0cea70d)'
| software_versions | Software versions loaded from ./11/software_mqc_versions.yml is not in a valid format, ignoring the file.

Worse - not just that version string, but all versions within that file.

Tagging @vladsavelyev @pontushojer

[vladsavelyev]

I agree that it doesn't make sense to attempt to parse versions, any string should be allowed 👍

Pushed a commit.