Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging spillover #2174

Merged
merged 31 commits into from Nov 14, 2023
Merged

Fix logging spillover #2174

merged 31 commits into from Nov 14, 2023

Conversation

vladsavelyev
Copy link
Member

Fixes #2173

There were several sources of logging outside the main multiqc logger:

  • Warnings about unknown to Python escape sequences (\d, \W, etc.) in regular expressions. To make it intentional and remove the warning, escape them with a raw specifier (r"").
  • Using the logging module directly vs the logger object (in one place).
  • A print leftover in the VEP module.

@vladsavelyev vladsavelyev added this to the MultiQC v1.18 milestone Nov 14, 2023
@vladsavelyev vladsavelyev added the bug: core Bug in the main MultiQC code label Nov 14, 2023
@vladsavelyev vladsavelyev added the awaits-review Awaiting final review and merge. label Nov 14, 2023
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ewels
Copy link
Member

ewels commented Nov 14, 2023

ngsderive is throwing a warning with colours, which is why that statement was being triggered:

|         ngsderive | Found 2 reports
|        mqc_colour | ngsderive_instruments_plot: Error getting colour: could not convert string to float: 'e'
|        mqc_colour | ngsderive_instruments_plot: Error getting colour: could not convert string to float: 'e'

Base automatically changed from add-ruff-linter to master November 14, 2023 10:27
@vladsavelyev vladsavelyev merged commit 398cf1a into master Nov 14, 2023
6 checks passed
@ewels ewels deleted the fix-logging-spill branch November 14, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-review Awaiting final review and merge. bug: core Bug in the main MultiQC code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging problem with full Test Data suite.
3 participants