Fastp: search pattern: look at content instead of file name #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladsavelyev
added
awaits-review
|
🚀 Deployed on https://mqc-pr-2213--multiqc.netlify.app |
4 tasks
ewels
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2172
MultiQC requires fastp inputs to end with
*fastp.json(#2172 (comment)), but we actually have enough data to tell them apart if we require any "*.json" and check for one or more lines that we always expect there to be.It would be nicer to be able to check for
fastp_version, but it was only added 2 years ago: OpenGene/fastp@8c8ddb6