Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kraken: fix UnboundLocalError #2230

Merged
merged 4 commits into from Dec 15, 2023
Merged

Kraken: fix UnboundLocalError #2230

merged 4 commits into from Dec 15, 2023

Conversation

vladsavelyev
Copy link
Member

Fix #1877

@vladsavelyev vladsavelyev added bug: module Bug in a MultiQC module awaits-review Awaiting final review and merge. labels Dec 14, 2023
@vladsavelyev vladsavelyev added this to the MultiQC v1.19 milestone Dec 14, 2023
@vladsavelyev vladsavelyev mentioned this pull request Dec 14, 2023
Closed
4 tasks
ewels
ewels approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ewels ewels merged commit 4c74197 into master Dec 15, 2023
6 checks passed
@ewels ewels deleted the kraken-fix branch December 15, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
awaits-review Awaiting final review and merge. bug: module Bug in a MultiQC module
Projects
None yet
Milestone
MultiQC v1.19: Xmas
Development

Successfully merging this pull request may close these issues.

UnboundLocalError sorted_pct in kraken module
3 participants
@vladsavelyev @ewels @multiqc-bot