multiqc: config: Catch FileNotFoundError when git is not installed.

[wwood]

Without this patch, the incorrect exception is caught when git is not in PATH.

[ewels]

Ah rubbish, I hadn't thought of this scenario. Many thanks @wwood. Note that the FileNotFoundError exception type doesn't seem to be available in Python 2 though.

Phil

[wwood]

So travis says. Well, for the purposes of Guix, that doesn't matter since python3 is used for running multiqc. I'm also not sure of the best way to handle this 2/3 problem, so I'll leave it to others to fix more generally.

Thanks for the quick response.

[ewels]

Thanks @wwood - I'm away on holiday now and won't be back until mid-February. A quick google suggests that using the base exception class IOError instead of FileNotFound should work for both Python 2 and 3, but I can't test here unfortunately. If you update your PR with that and Travis passes I'd be happy to merge from here though.

Cheers,

Phil

[ewels]

Hi @wwood,

I've just pushed a change which just handles any exception triggered by this code. Not great coding practice, but as this is such an unimportant feature I don't think that it should ever halt the execution of MultiQC. As a bonus, it should work with both Python 2 and 3 😅

Hope this is ok, let me know how you get on with the change. Thanks again for the PR..

Phil