Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typer autocomplete on constructor #57

Closed
Kludex opened this issue Apr 16, 2022 · 3 comments
Closed

Typer autocomplete on constructor #57

Kludex opened this issue Apr 16, 2022 · 3 comments
Labels
new feature New feature or request

Comments

@Kludex
Copy link

Kludex commented Apr 16, 2022

I want to have autocompletion when instantiating a Typer object.

Can I open a PR with it? It will be verbose.

@ewels
Copy link
Owner

ewels commented Apr 16, 2022

Sure! I'm not very familiar with Typer so I'm not entirely sure what you mean, but go for it.

Note that if / when Typer gets native support for rich-click (or something like it), I will remove Typer support from this library. Just so you know :)

I'm about to head off on holiday and then start a new job, so be warned that it'll likely be at least a couple of weeks before I get to reviewing anything 👍🏻

@Kludex
Copy link
Author

Kludex commented Apr 16, 2022

Note that if / when Typer gets native support for rich-click (or something like it), I will remove Typer support from this library. Just so you know :)

Noted.

Sure! I'm not very familiar with Typer so I'm not entirely sure what you mean, but go for it.

When you instantiate the Typer object, you don't have autocomplete because the rich_click.typer.Typer.__init__ uses args and kwargs:

image

My goal is to not have to check what Typer parameters are accepted elsewhere.

I'm about to head off on holiday and then start a new job, so be warned that it'll likely be at least a couple of weeks before I get to reviewing anything 👍🏻

That's exciting! Have a pleasant holiday, and enjoy your new adventure! 🤩

I'll be opening a PR at some point - if someone is reading this, and want to do it, go ahead.

@ewels ewels added the new feature New feature or request label Apr 27, 2022
@ewels ewels linked a pull request Apr 27, 2022 that will close this issue
@ewels
Copy link
Owner

ewels commented May 14, 2022

Closing for now, can reopen if there is a lot of interest.

@ewels ewels closed this as completed May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants