Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete for typer #58

Closed
wants to merge 1 commit into from
Closed

Add autocomplete for typer #58

wants to merge 1 commit into from

Conversation

Kludex
Copy link

@Kludex Kludex commented Apr 18, 2022

The Typer in the image below is from this PR. Installed via rich-click @ git+https://github.com/Kludex/rich-click@add-autocomplete-typer.

image

The idea of this PR is to improve the autocompletion on the rich_click.typer proxy.

@ewels
Copy link
Owner

ewels commented Apr 27, 2022

Whilst I see the point of this, I can't say that I love the change. It makes the code much messier and I can imagine it being fairly easy to get errors triggered by variations of installed package versions (when we don't actually care about all of these arguments).

Is there really no other way to achieve this? 😕 I'm a bit on the fence as to whether the benefits outweigh the disadvantages here.

@ewels ewels linked an issue Apr 27, 2022 that may be closed by this pull request
@Kludex
Copy link
Author

Kludex commented Apr 27, 2022

No other way to achieve this.

I'm already using this branch. If this is not merged, I can always mimic the implementation of this PR. No harm in closing it.

@ewels
Copy link
Owner

ewels commented May 14, 2022

I think I'll close for now if that's ok. I'm worried that the burden of maintaining this will be too great, and at the end of the day it's for a mostly-cosmetic advantage. We can revisit if lots of other people start requesting it (note that hopefully Typer will have built-in support for this kind of CLI output already so this package may become redundant for Typer).

@ewels ewels closed this May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typer autocomplete on constructor
2 participants