Feat #89 isolation and extensibility design #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `command.get_usage` method generates the usage string by writing it to a new formatter. This caused Rich to apply the styles twice.
|
@davidbrochart - I'm having issues updating this PR due to conflicts in Are you able to help me figure out what your command syntax should look like with this new |
|
I tried in #104, but not sure of myself. |
ewels
commented
Apr 12, 2023
|
ok, I'm merging this before any more merge conflicts crop up. I'm still not totally clear on what all of the code changes do, but I am pretty sure that it's a major improvement over the current state. If people find any problems then hopefully we can sort them relatively fast. Massive thanks to @BrutalSimplicity for this work! 🙇🏻 |
Replace click_group with click_command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #92 in a new PR, so that I can force-push to remove some commits.