Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rich-codex screengrabs #106

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Update rich-codex screengrabs #106

merged 1 commit into from
Apr 20, 2023

Conversation

ewels
Copy link
Owner

@ewels ewels commented Apr 12, 2023

No description provided.

@ewels
Copy link
Owner Author

ewels commented Apr 12, 2023

Ok, this PR is quite useful and highlights a few regressions that have crept in I think:

Broken rich output in custom errors:

  • Note invalid escape codes in the terminal (not just rich-codex, I get this when running the command manually too)
  • This is for all errors, not just this script
$ python examples/07_custom_errors.py --hep

 Usage: 07_custom_errors.py [1;36mOPTIONS]
 1;36mINPUT

 Try running the '--help' flag for more information.
╭─ Error ───────────────────────────────────────────────────────╮
│ No such option: --hep Did you mean --help?                    │
╰───────────────────────────────────────────────────────────────╯

 To find out more, visit https://mytool.com

Change in whitespace

  • The Usage: line no longer has a leading space, giving inconsistent padding with the rest of the output.
  • We lost a newline before the Usage: and gained a duplicate after it
  • We lost the final blank newline at the end of the output (not necessary a bad thing, don't mind this much).

@ewels ewels force-pushed the Update-rich-codex-screengrabs branch 2 times, most recently from 760bb19 to 9591f40 Compare April 20, 2023 22:59
@ewels ewels force-pushed the Update-rich-codex-screengrabs branch from 9591f40 to 11ae68f Compare April 20, 2023 23:13
@ewels ewels merged commit 8e7523c into main Apr 20, 2023
@ewels ewels deleted the Update-rich-codex-screengrabs branch April 20, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant