Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix strategy for CI + fix for Click 7.x. #113

Merged
merged 4 commits into from
Jul 16, 2023

Conversation

dwreeves
Copy link
Collaborator

Fixes #112, and lays groundwork for resolving #18.

Overview

I was working on resolving #18 when I noticed that the solution to this involves branching logic for Click 8 and Click 7.

I also noticed this library is getting more popular (congrats!) and people are starting to use it for more things.

In light of all this, I thought that before I address #18, I should significantly expand the scope of the CI so that all versions of Click that you say are supported, actually are supported.

Uncovering some regressions with Click 7.x support

In doing this, I discovered that the latest version of the code base in main actually has quite a few Click 7.x regressions.

In this code, I've fixed every regression I could see, except support for rich_config, which I could not get working.

Some of the regression fixes aren't the prettiest, but the fixes appear to work just fine.

Where to go from here

I feel like you can either keep as is, or you can add deprecation warnings for support to click 7.x and then remove that support in a future release.

@ewels
Copy link
Owner

ewels commented Jul 16, 2023

This is massive, thanks for the work you've put into this!

I'm very happy to drop support for Click 7x. Click 8 has been around for a while now (since 2020) which I think is a fair period. And people can always install earlier versions of rich-click if that support was critical.

I'll merge now but if you fancy adding in some depreciation warnings within another PR that would be fab 👍🏻

@ewels ewels merged commit 12f52d2 into ewels:main Jul 16, 2023
34 checks passed
@dwreeves
Copy link
Collaborator Author

I'll add some deprecation warnings, that sounds fine to me. So I have two PRs on my plate:

Thank you for merging this!

@ewels
Copy link
Owner

ewels commented Jul 16, 2023

Perfect, thank you!

@dwreeves dwreeves mentioned this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in support for click 7.* in main branch (1.7.0dev, unreleased)
2 participants