Deprecate click 7.x support #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwreeves
force-pushed
the
116-deprecate-click-7
branch
from
d9dd19f
to
25ba376
Compare
|
Probably should have added a changelog entry for this.. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #116
Mostly self-explanatory PR.
I did not add TODO comments because all the parts of the code that need to be changed are easy enough to find in the code (basically, anywhere that
CLICK_IS_BEFORE_VERSION_8Xis referenced).Lastly, on the topic of deprecation warnings, I removed
distutiils.version.LooseVersionand swapped withpackaging.version.parsesincedistutiilsis deprecated and is slated to be removed in Python 3.12, via PEP-632 https://peps.python.org/pep-0632/ And I don't see any good reason for the next version release to not work with Python 3.12, even if only temporarily.