Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rich style bugs #136

Merged
merged 3 commits into from
Oct 9, 2023
Merged

fix rich style bugs #136

merged 3 commits into from
Oct 9, 2023

Conversation

dwreeves
Copy link
Collaborator

@dwreeves dwreeves commented Oct 9, 2023

Resolves #135. A handful of things were not hooked up properly.

Also, I added a new thing to the API, the style_errors_suggestion_command. I also included an example of that in the README.

@dwreeves
Copy link
Collaborator Author

dwreeves commented Oct 9, 2023

After studying the rich config API a little bit, and trying to grasp the intentions of each attribute, I am pretty comfortable with the way I approached this! I have also tested this change a decent bit, and also documented the one thing I am adding to the interface.

I will just merge without approval of Phil once the CI passes, I am possibly bugging him too much... 😅

@dwreeves dwreeves merged commit 2925737 into ewels:main Oct 9, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: commands are always bold cyan and a few more style bugs.
1 participant