fix: approvals stuck on checking for conflicts #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was happening if another development solution contains an entity which the development solution being approved does not contain.
ewingjm
deleted the
bugfix/some-approvals-stuck-on-checking-for-conflicts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approving a solution merge would sometimes get stuck on the 'checking for conflicts' notification. This would happen if another development solution contained an entity which the development solution being approved did not contain.
Approach
Fixes an issue in the web resource where it was attempting to get subcomponents for an entity that wasn't in the solution.
TODOs