minimode: Progress and Playlist buttons show a popup and then immediately closes it #222
Comments
Previously the code attempts to hide the AttachedWindow when the focus goes back to the parent window. However, the interaction is brittle and can cause the AttachedWindow to be immediately hidden after being shown (see the linked bug). Rather than putting more effort towards making AttachedWindow behave like a popup, this patch simplifies the code and removes the focus-related hiding behavior, making it more like a normal window instead. AttachedWindow is now using the standard behavior in the "transient-for" window relationship. The only important thing that AttachedWindow still does is placing itself correctly and following the parent's position. Tested on Windows. Partial work for #222
|
The linked commits fix this, but also change how the Playlist window works. It now doesn't close automatically; you have to click on the toggle button again to close it. |
|
It did not work for me in Exaile 3.4.5. I just changed the two files /etc/lib/exaile/xlgui/widgets/common.py and /etc/share/exaile/plugins/minimode/controls.py with the files provided in fixes b1c7694 and a584180. After the fixes, Exaile fails to launch altogether. After just the fix a584180, plugin Minimode fails to load. |
|
I tweaked a bit with the changes you proposed in the fix a584180. It works perfectly and solves the issue for me when I just remove the lines 792 to 819 in /etc/share/exaile/plugins/minimode/controls.py as you have mentioned, without making any other changes. Thank you! |
In 3.x and 4.x.
The text was updated successfully, but these errors were encountered: