Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #604 #612

Merged
merged 2 commits into from
Apr 8, 2019
Merged

Conversation

TheTumultuousUnicornOfDarkness
Copy link
Contributor

No description provided.

In dist.sh line 5:
THISDIR=/usr/bin
        ^----------^ SC2006: Use  notation instead of legacy backticked .
                 ^-- SC2086: Double quote to prevent globbing and word splitting.

In dist.sh line 6:
EXAILE_DIR=/..
^--------^ SC2034: EXAILE_DIR appears unused. Verify use (or export if used externally).

In dist.sh line 8:
if [[ -n  ]]; then
   ^----------------------^ SC2039: In POSIX sh, [[ ]] is undefined.

In dist.sh line 27:
    -cf dist/exaile-.tar.gz                     ^-------------^ SC2086: Double quote to prevent globbing and word splitting.
@virtuald
Copy link
Member

virtuald commented Apr 8, 2019

Looks like it worked! Thanks!

@TheTumultuousUnicornOfDarkness
Copy link
Contributor Author

Nice, I hope it is all good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants