Negative start and stop offset per track #753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a reasonable feature to add. If you rebase and add the stop offset I would be happy to merge it. It would be good to add some unit tests for this, but I suppose that's not really doable at this time. |
…' into negative_start_offset_per_treack
|
Rebasing did weird things. So this PR continues in #785 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ability of negative start and stop offset per track.
So it would be possible to have a different gaps between the tracks and to have all tracks starting and ending with 3 seconds of silence.
Most work is in xl/player/player.py. The play function now adds a GLib-Timeout in case of negative start offset for delaying.
This PR is a draft and implements only the start offset. If you find it usefull and okay I would implement the stop offset also.