tools/installer: switch to upstream PyInstaller #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokm
force-pushed
the
upstream-pyinstaller
branch
from
a9431f8
to
85a9c7f
Compare
sjohannes
reviewed
Jan 4, 2023
Comment on lines
-67
to
-72
| def _exclude(b): | ||
| for r in to_remove: | ||
| if r in b and 'libgstvideo-1' not in b: | ||
| print("Excluding", b) | ||
| return True | ||
| return False |
There was a problem hiding this comment.
I don't remember what this is for; is it not needed anymore?
There was a problem hiding this comment.
This is how we were removing the unwanted gstreamer plugins up until now; it is part of the assemble_hook function, which was executed by our modified PyInstaller before performing binary analysis.
The same can now be achieved by explicitly filtering gstreamer plugins via PyInstaller's hook configuration.
Exclude GStreamer plugins via corresponding hook configuration option that was introduced in PyInstaller 5.4. Switch to upstream PyInstaller release instead of using private fork.
rokm
force-pushed
the
upstream-pyinstaller
branch
from
85a9c7f
to
ff87b7f
Compare
Include exaile.spec file in auto-formatting and formatting check via black auto-formatter.
|
This should now collect (or rather, exclude) the same plugins as the old approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude GStreamer plugins via corresponding hook configuration option that was introduced in PyInstaller 5.4. Switch to upstream PyInstaller release instead of using private fork.