Merge pull request #3 from smarchive/puppet-lint

Fix warnings and errors for puppet-lint
example42 · Jan 10, 2013 · ecbe641 · ecbe641
2 parents 7926780 + 5a66af8
commit ecbe641
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/manifests/init.pp b/manifests/init.pp
@@ -20,8 +20,8 @@
     # FIXME: Unsure if this should be in firewall or iptables. Maybe both?
     # iptables-restore v1.3.5: Unknown arg `--dport'
     # -A INPUT  --dport 21   -j REJECT
-    if ($protocol == "") and ($port) {
-      fail("FIREWALL: Protocol must be set if port is set.")
+    if ($protocol == '') and ($port) {
+      fail('FIREWALL: Protocol must be set if port is set.')
     }
 
     $iptables_chain = $direction ? {
@@ -35,8 +35,8 @@
       'drop'    => 'DROP',
 
       'reject'  => $protocol ? {
-        'tcp'   => "REJECT --reject-with tcp-reset",
-        default => "REJECT", 
+        'tcp'   => 'REJECT --reject-with tcp-reset',
+        default => 'REJECT',
       },
 
       default   => 'ACCEPT',